Merge lp://qastaging/~3v1n0/gtk/unity-border-radius-support into lp://qastaging/~ubuntu-desktop/gtk/ubuntugtk3
Proposed by
Marco Trevisan (Treviño)
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Sebastien Bacher | ||||
Approved revision: | 511 | ||||
Merged at revision: | 509 | ||||
Proposed branch: | lp://qastaging/~3v1n0/gtk/unity-border-radius-support | ||||
Merge into: | lp://qastaging/~ubuntu-desktop/gtk/ubuntugtk3 | ||||
Diff against target: |
363 lines (+279/-56) 4 files modified
debian/changelog (+9/-0) debian/patches/series (+1/-1) debian/patches/unity-border-radius.patch (+269/-0) debian/patches/unity_rbga_tooltips.patch (+0/-55) |
||||
To merge this branch: | bzr merge lp://qastaging/~3v1n0/gtk/unity-border-radius-support | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher | Approve | ||
desrt (community) | Needs Fixing | ||
Review via email: mp+288331@code.qastaging.launchpad.net |
Description of the change
Export windows corners radius as an X11 property in unity.
It works together with lp:~3v1n0/unity/gtk-border-radius-support/+merge/288358
To post a comment you must log in.
Looks pretty good, but there are some things that I would consider changing.
I am not an expert in GTK theming by any measure, however, so my suggestions might be pure insanity. I just took a look at how some other widgets are doing things.
One comment in general: do we really need to query the title widget to find out the borders that will be drawn on the toplevel? Something seems wrong here. I would have expected that we can query this information directly from the window itself in some way (and avoid the ugly hacks about assuming zeros).