Merge lp://qastaging/~dpm/ubuntu-rssreader-app/enable-translations into lp://qastaging/~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Proposed by David Planella
Status: Merged
Approved by: Roman Shchekin
Approved revision: 79
Merged at revision: 72
Proposed branch: lp://qastaging/~dpm/ubuntu-rssreader-app/enable-translations
Merge into: lp://qastaging/~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 781 lines (+487/-66)
18 files modified
.bzrignore (+2/-1)
README.translations (+36/-0)
dateutils.js (+6/-0)
debian/changelog (+7/-0)
debian/control (+9/-9)
debian/rssreader-app.install (+9/-9)
debian/rules (+9/-0)
feeds/AppendFeedPage.qml (+2/-2)
feeds/ChooseTopicPage.qml (+1/-1)
feeds/CreateTopicPage.qml (+1/-1)
feeds/ManageFeedsPage.qml (+1/-1)
listview/ArticleListPage.qml (+1/-1)
po/po.pro (+44/-33)
po/rssreader-app.pot (+336/-0)
rssreader-app (+1/-1)
rssreader-app.desktop (+3/-3)
rssreader-app.qmlproject (+16/-1)
tests/autopilot/ubuntu_rssreader_app/tests/__init__.py (+3/-3)
To merge this branch: bzr merge lp://qastaging/~dpm/ubuntu-rssreader-app/enable-translations
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Shorts Developers Pending
Review via email: mp+187690@code.qastaging.launchpad.net

Commit message

Enable the translations infrastructure: expose translations in Launchpad and build/ship them in the Debian package.

Description of the change

NOTE: if you do a review, feel free to approve/disapprove in the comments, but do not top-approve yet, as this needs to be coordinated with the package name change in the seeds.

Enable the translations infrastructure: expose translations in Launchpad and build/ship them in the Debian package.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Joey Chan (qqworini) wrote :

Oh no... Roman, didn't u read the "Description of the Change" ? David said "do not top-approve" because of some reasons

Revision history for this message
David Planella (dpm) wrote :

Yes, please read the comments on the next occasion.

We'll sort it out, it's all good, but we need to do some extra coordination to get this landed, as it changes the package name.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches