Odoo Server (MOVED TO GITHUB)

Merge lp://qastaging/~0k.io/openobject-server/correct-syntax-error-default-view-for-base-calendar into lp://qastaging/openobject-server

  1. correct-syntax-error-default-view-for-base-calendar
  2. Merge into trunk
Proposed by Valentin Lab
Status: Needs review
Proposed branch: lp://qastaging/~0k.io/openobject-server/correct-syntax-error-default-view-for-base-calendar
Merge into: lp://qastaging/openobject-server
Diff against target: 12 lines (+1/-1)
1 file modified
openerp/osv/orm.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~0k.io/openobject-server/correct-syntax-error-default-view-for-base-calendar
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+169482@code.qastaging.launchpad.net

Description of the change

Without this modification, the given code will cast a syntax error. SubElement method does not support *args but only **kwargs after the second argument:

api of subelement:

  http://lxml.de/api/lxml.etree-module.html

in short, here's the prototype as of the later link:

  SubElement(_parent, _tag, attrib=None, nsmap=None, **_extra)

So, you can't provide a third non-keyword argument (or else it'll be taken as ``attrib``, which is required to be a dict, not a string).

Read the bug report associated, and if any doubt, lookup other calls in the same file of SubElements.

To post a comment you must log in.

Unmerged revisions

4901. By Valentin Lab

[FIX] syntax error in default calendar view creation.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.