Merge lp://qastaging/~3v1n0/bamf/fixes into lp://qastaging/bamf/0.4
| Status: | Merged | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 412 | ||||||||||||
| Proposed branch: | lp://qastaging/~3v1n0/bamf/fixes | ||||||||||||
| Merge into: | lp://qastaging/bamf/0.4 | ||||||||||||
| Diff against target: |
1121 lines (+555/-236) 3 files modified
src/bamf-application.c (+27/-14) src/bamf-application.h (+4/-4) src/bamf-matcher.c (+524/-218) |
||||||||||||
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/bamf/fixes | ||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jason Smith (community) | Approve | ||
| Unity Community Hackers | Pending | ||
|
Review via email:
|
|||
Description of the change
This is a branch I'm working on during my spare time since some weeks; it includes some BAMF miscellaneous fixes.
- Improved desktop folders monitoring support (fix bug #676593) supporting monitoring
newly added .desktop files, newly added folders containing .desktop files
(recursively), edited .desktop files (reducing the rate limit, to save CPU)
- Correctly clear from BAMF cache .desktop files that are removed from system
- Order correctly the .desktop file keeping their priority
- Support the ~/Desktop folder and $XDG_DATA_HOME as .desktop storages (with
highest priority, the order will be kept when adding new files) bug #768636
- Some memory leaks and coding style fixes...
I would have added also the support for dynamically update a bamf_application when a .desktop file (that matches it) is removed, but I guess that it's not vital... On next application reload the user will notice the change (however, if it is requested, I've already done something in it).
For more informations, look at the logs [1]; I've wrote anything there.
+1 looks good :)
runs well too!