Merge lp://qastaging/~3v1n0/bamf/javaws-ignore-desktop-0.3 into lp://qastaging/bamf/0.3

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 506
Merged at revision: 498
Proposed branch: lp://qastaging/~3v1n0/bamf/javaws-ignore-desktop-0.3
Merge into: lp://qastaging/bamf/0.3
Diff against target: 477 lines (+243/-22)
8 files modified
src/bamf-legacy-window-test.c (+21/-0)
src/bamf-legacy-window-test.h (+1/-0)
src/bamf-legacy-window.c (+47/-0)
src/bamf-legacy-window.h (+4/-0)
src/bamf-matcher-private.h (+1/-0)
src/bamf-matcher.c (+50/-19)
tests/bamfdaemon/data/icedtea-netx-javaws.desktop (+12/-0)
tests/bamfdaemon/test-matcher.c (+107/-3)
To merge this branch: bzr merge lp://qastaging/~3v1n0/bamf/javaws-ignore-desktop-0.3
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
Review via email: mp+145294@code.qastaging.launchpad.net

Commit message

BamfMatcher: ignore the javaws windows when setting the window hint

Description of the change

Backport to Bamf-0.3 of lp:~3v1n0/bamf/javaws-ignore-desktop/+merge/145289

We need to avoid that a Java Web Application is associated with the default "Java Web Start" .desktop file provided by java as the default opener for jnlp files, or the bug #1098186 will show again.

Test added.

To post a comment you must log in.
500. By Marco Trevisan (Treviño)

Tests: add the missing icedtea-netx-javaws.desktop file

501. By Marco Trevisan (Treviño)

TestMatcher: fix javawm class names

502. By Marco Trevisan (Treviño)

BamfLegacyWindow: add a function to fetch the process name

503. By Marco Trevisan (Treviño)

BamfLegacyWindowTest: implement the get_process_name function

504. By Marco Trevisan (Treviño)

BamfMatcher: add bamf_matcher_is_valid_process_prefix to check for bad prefix process

Now we ignore the bad process prefixes also when using the
fallback process-name comparison. In this way the .desktop files
that they may provide to load files are ignored.

505. By Marco Trevisan (Treviño)

TestMatcher: added one more test to ensure javaws matching

506. By Marco Trevisan (Treviño)

BamfMatcher: fix compilation issues

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches