BAMF

Merge lp://qastaging/~3v1n0/bamf/javaws-matching into lp://qastaging/bamf/0.4

  1. javaws-matching
  2. Merge into 0.4
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 529
Merged at revision: 516
Proposed branch: lp://qastaging/~3v1n0/bamf/javaws-matching
Merge into: lp://qastaging/bamf/0.4
Diff against target: 332 lines (+140/-45)
3 files modified
src/bamf-legacy-window.c (+25/-41)
src/bamf-matcher.c (+34/-4)
tests/bamfdaemon/test-matcher.c (+81/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/bamf/javaws-matching
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Brandon Schaefer (community) Approve
Review via email: mp+142617@code.qastaging.launchpad.net

Commit message

BamfMatcher: Don't associate .desktopless applications with different exec string, fix JavaWS apps

Description of the change

Don't associate to the similar application, windows that have different execution path. Also add some rules to fix Java Web Start applications matching.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:529
http://jenkins.qa.ubuntu.com/job/bamf-mbs-ci/30/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-mbs-ci/./build=pbuilder,distribution=quantal,flavor=amd64/30/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-mbs-ci/./build=pbuilder,distribution=quantal,flavor=i386/30/console

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/bamf-mbs-ci/30//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Unapproved changes made after approval.
http://jenkins.qa.ubuntu.com/job/bamf-mbs-autolanding/53/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-mbs-autolanding/./build=pbuilder,distribution=raring,flavor=amd64/53/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-mbs-autolanding/./build=pbuilder,distribution=raring,flavor=i386/53/console

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches