Merge lp://qastaging/~3v1n0/bamf/libbamf-load-favorites-sticky-values-0.4 into lp://qastaging/bamf/0.4

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 546
Merged at revision: 536
Proposed branch: lp://qastaging/~3v1n0/bamf/libbamf-load-favorites-sticky-values-0.4
Merge into: lp://qastaging/bamf/0.4
Diff against target: 772 lines (+298/-75)
22 files modified
Makefile.am (+1/-3)
configure.ac (+1/-0)
lib/libbamf/bamf-application.c (+82/-40)
lib/libbamf/bamf-view.c (+6/-3)
lib/libbamf/bamf-view.h (+1/-1)
src/bamf-application.c (+9/-8)
tests/Makefile.am (+10/-0)
tests/Makefile.am.gtests (+0/-1)
tests/bamfdaemon/Makefile.am (+0/-1)
tests/bamfdaemon/test-application.c (+4/-5)
tests/bamfdaemon/test-bamf.c (+1/-1)
tests/bamfdaemon/test-matcher.c (+1/-1)
tests/bamfdaemon/test-view.c (+0/-7)
tests/bamfdaemon/test-window.c (+1/-2)
tests/data/bin/mime-test-text-editor (+3/-0)
tests/data/bin/unity-webapps-runner (+3/-0)
tests/data/full-name.desktop (+7/-0)
tests/data/invalid-type.desktop (+5/-0)
tests/data/ubuntu-web-app.desktop (+5/-0)
tests/libbamf/Makefile.am (+4/-2)
tests/libbamf/test-application.c (+149/-0)
tests/libbamf/test-libbamf.c (+5/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/bamf/libbamf-load-favorites-sticky-values-0.4
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+165688@code.qastaging.launchpad.net

Commit message

libbamf: BamfApplication: cache MimeTypes and ApplicationType on favorite and sticky apps

Description of the change

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
543. By Brandon Schaefer

TestBamfDaemon: don't check for GLIB type on deleted pointers

544. By Marco Trevisan (Treviño)

TestLibBamf: remove unsafe type check on deleted pointer

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
545. By Marco Trevisan (Treviño)

TestLibBamf: init gtk or the dbus initialization won't work

546. By Marco Trevisan (Treviño)

Makefile.am.gtests: remove sleep, no one likes to sleep when unneed...

Really? :)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Yay! LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches