Merge lp://qastaging/~3v1n0/bamf/libbamf-load-favorites-sticky-values into lp://qastaging/bamf
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Marco Trevisan (Treviño) |
| Approved revision: | 546 |
| Merged at revision: | 535 |
| Proposed branch: | lp://qastaging/~3v1n0/bamf/libbamf-load-favorites-sticky-values |
| Merge into: | lp://qastaging/bamf |
| Diff against target: |
947 lines (+383/-88) 26 files modified
Makefile.am (+1/-2) Makefile.am.coverage (+11/-8) configure.ac (+1/-0) debian/control (+1/-0) lib/libbamf/bamf-application.c (+82/-40) lib/libbamf/bamf-view.c (+6/-3) lib/libbamf/bamf-view.h (+1/-0) src/Makefile.am (+0/-1) src/bamf-application.c (+9/-8) tests/Makefile.am (+10/-0) tests/Makefile.am.gtests (+13/-7) tests/bamfdaemon/Makefile.am (+2/-1) tests/bamfdaemon/test-application.c (+4/-5) tests/bamfdaemon/test-bamf.c (+1/-1) tests/bamfdaemon/test-matcher.c (+1/-1) tests/bamfdaemon/test-view.c (+0/-7) tests/bamfdaemon/test-window.c (+1/-2) tests/data/bin/mime-test-text-editor (+3/-0) tests/data/bin/unity-webapps-runner (+3/-0) tests/data/full-name.desktop (+7/-0) tests/data/invalid-type.desktop (+5/-0) tests/data/ubuntu-web-app.desktop (+5/-0) tests/gtester2xunit.py (+56/-0) tests/libbamf/Makefile.am (+6/-2) tests/libbamf/test-application.c (+149/-0) tests/libbamf/test-libbamf.c (+5/-0) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/bamf/libbamf-load-favorites-sticky-values |
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Brandon Schaefer (community) | Approve | ||
|
Review via email:
|
|||
Commit message
libbamf: BamfApplication: cache MimeTypes and ApplicationType on favorite and sticky apps
Description of the change
When a BamfApplication is created from a local desktop file or is sticked we need to chache the relevant values so that they can be available also when the view is not exported on dbus.
Fixed a memory leak (mime types were never free'd)
Tests added.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| Allan LeSage (allanlesage) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:535
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://