BAMF

Merge lp://qastaging/~3v1n0/bamf/use-bigger-icons into lp://qastaging/bamf

  1. use-bigger-icons
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 594
Merged at revision: 582
Proposed branch: lp://qastaging/~3v1n0/bamf/use-bigger-icons
Merge into: lp://qastaging/bamf
Diff against target: 73 lines (+10/-2)
5 files modified
configure.ac (+1/-1)
debian/changelog (+1/-0)
debian/control (+1/-1)
lib/libbamf-private/bamf-private.h (+3/-0)
src/bamf-legacy-screen.c (+4/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/bamf/use-bigger-icons
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Andrea Azzarone (community) Approve
Review via email: mp+181073@code.qastaging.launchpad.net

Commit message

BamfLegacyScreen: use bigger icons size by default

libwnck would just use 32 and 16 sized icons, while we can safely use bigger versions.

Description of the change

This needs new libwnck (3.4.7 or https://git.gnome.org/browse/libwnck/commit/?id=7b9f3a3) about to land in ubuntu soon.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:592
http://jenkins.qa.ubuntu.com/job/bamf-ci/88/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-amd64-ci/69/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-armhf-ci/70/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/bamf-ci/88/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:592
http://jenkins.qa.ubuntu.com/job/bamf-ci/89/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-saucy-amd64-ci/70
    SUCCESS: http://jenkins.qa.ubuntu.com/job/bamf-saucy-armhf-ci/71

Click here to trigger a rebuild:
http://s-jenkins:8080/job/bamf-ci/89/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/bamf-autolanding/53/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-amd64-autolanding/45/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-armhf-autolanding/44/console
    FAILURE: http://s-jenkins:8080/job/generic-cleanup-mbs/1566/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:593
http://jenkins.qa.ubuntu.com/job/bamf-ci/90/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-amd64-ci/71/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-saucy-armhf-ci/72/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/bamf-ci/90/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~3v1n0/bamf/use-bigger-icons updated
594. By Marco Trevisan (Treviño)

Merging with trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches