BAMF

Merge lp://qastaging/~3v1n0/bamf/valgrind-fixes into lp://qastaging/bamf/0.4

  1. valgrind-fixes
  2. Merge into 0.4
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Jason Smith
Approved revision: 466
Merged at revision: 454
Proposed branch: lp://qastaging/~3v1n0/bamf/valgrind-fixes
Merge into: lp://qastaging/bamf/0.4
Diff against target: 448 lines (+95/-78)
4 files modified
src/bamf-application.c (+2/-2)
src/bamf-matcher.c (+78/-63)
src/bamf-view.c (+8/-7)
src/bamf-view.h (+7/-6)
To merge this branch: bzr merge lp://qastaging/~3v1n0/bamf/valgrind-fixes
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+98007@code.qastaging.launchpad.net

Commit message

Fix memory leaks and some read errors in Bamf

Description of the change

Fix some BAMF read errors and memory leaks.

To post a comment you must log in.
lp://qastaging/~3v1n0/bamf/valgrind-fixes updated
463. By Marco Trevisan (Treviño)

BamfMatcher: cleanup bamf_matcher_unregister_view

464. By Marco Trevisan (Treviño)

BamfMatcher: moving to g_list_find + g_list_delete_link

465. By Marco Trevisan (Treviño)

BamfMatcher: use a while loop in dispose function, to unregister views.

466. By Marco Trevisan (Treviño)

BamfMatcher: rename bamf_matcher_register_view into bamf_matcher_register_view_stealing_ref

Revision history for this message
Michal Hruby (mhr3) wrote :

I can't say I like too much the stealing behavior, but at least it's super obvious that it steals the ref, other than that it's looking good, yey for fewer leaks :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches