lp://qastaging/~3v1n0/compiz/ccp-core-options-save-fix

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/compiz/0.9.9 at revision 3603

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2013-02-11

Sam Spilsbury: Approve on 2013-02-11

Diff: 43 lines (+16/-10)

1 file modified

plugins/ccp/src/ccp.cpp (+16/-10)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1122228: Calling setOptionForPlugin does not work for core options

High

Fix Released

Link a bug report

Related blueprints

3604. By Marco Trevisan (Treviño) on 2013-02-11

Ccp: always set CompOption to NULL by default, don't check it if not needed

3603. By Marco Trevisan (Treviño) on 2013-02-11

Ccp: check if an option has changed before calling the base class

Otherwise core options (that is called before) won't never be correctly updated on
setOptionForPlugin call

3602. By PS Jenkins bot on 2013-02-08

Releasing 1:0.9.9~daily13.02.08-0ubuntu1, based on r3601

3601. By PS Jenkins bot on 2013-02-07

Releasing 1:0.9.9~daily13.02.07-0ubuntu1 to ubuntu.

Approved by PS Jenkins bot.

3600. By MC Return on 2013-02-07

Refactoring of thumbnail.xml.in:

Better structuring.

Converted 'Window Title Text' from subgroup to group,
thereby moving the text settings into their own tab.

Improved tooltips and titles.

Fixed indentation.

(LP: #1113459). Fixes: https://bugs.launchpad.net/bugs/1113459.

Approved by Sam Spilsbury.

3599. By MC Return on 2013-02-07

Cube Gears plugin:
Fixed the rendering of the inner cylinders by rendering them first.

(LP: #1117311). Fixes: https://bugs.launchpad.net/bugs/1117311.

Approved by Sam Spilsbury.

3598. By MC Return on 2013-02-06

Fixed cppcheck static code analysis errors/warnings/recommendations:

* Removed unused variable TfWindowList::iterator 'iter' in
  TrailfocusScreen::refillList ().

* Removed useless calculation of 'distance', because the calculated value
  is never used.

* Do not assign false to bool 'rv', because a new value is reassigned
  a few lines later, before the old one has been used.
  Declare and assign bool 'rv' in the same line instead.

* Used prefix ++ operator to increase 'rit' in the for loop, because
  pre-increment can be more efficient.

* Used prefix ++ operators to increase 'w' (x2) and 'it' in their
  respective for loops for the same reason.

* Commented out calculation of 'x2', because this value gets recalculated
  a few lines later, before having been used.

* int 'lco', 'rco', 'tco' and 'bco' got the value output assigned, but
  this value never was used, but all got new values assigned a few lines
  later.
  Declare and assign int 'lco', 'rco', 'tco' and 'bco' in the same line.

* The 'xv' and 'yv' variables are of type unsigned int, so %u is the right
  format to snprintf them, not %d.

(LP: #1114525). Fixes: https://bugs.launchpad.net/bugs/1114525.

Approved by Sam Spilsbury.

3597. By MC Return on 2013-02-05

Fixed compilation of the Cube Gears plugin.
Enabled gears plugin for GL builds.
Disabled gears plugin for GLES builds.

(LP: #1020822). Fixes: https://bugs.launchpad.net/bugs/1020822.

Approved by Timo Jyrinki, Brandon Schaefer, Sam Spilsbury.

3596. By MC Return on 2013-02-04

Fixed refres_rate->refresh_rate typos.

(LP: #1115243). Fixes: https://bugs.launchpad.net/bugs/1115243.

Approved by Didier Roche.

3595. By PS Jenkins bot on 2013-02-04

Releasing 1:0.9.9~daily13.02.04-0ubuntu1 to ubuntu.

Approved by Francis Ginther.