Compiz

Merge lp://qastaging/~3v1n0/compiz/client-frame-api into lp://qastaging/compiz/0.9.12

  1. client-frame-api
  2. Merge into 0.9.12
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Christopher Townsend
Approved revision: 3927
Merged at revision: 3967
Proposed branch: lp://qastaging/~3v1n0/compiz/client-frame-api
Merge into: lp://qastaging/compiz/0.9.12
Diff against target: 179 lines (+58/-4)
7 files modified
include/core/abiversion.h (+1/-1)
include/core/atoms.h (+1/-0)
include/core/window.h (+3/-1)
src/atoms.cpp (+4/-2)
src/event.cpp (+6/-0)
src/privatewindow.h (+3/-0)
src/window.cpp (+40/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/compiz/client-frame-api
Reviewer Review Type Date Requested Status
MC Return Approve
Christopher Townsend (community) Approve
Review via email: mp+250015@code.qastaging.launchpad.net

Commit message

Window: add clientFrame(), to get the client-side decoration extents

This only supports GTK at the moment, but it might be adapted to other toolkits.

To post a comment you must log in.
Revision history for this message
Christopher Townsend (townsend) wrote :

Ok, looks good and build fine.

review: Approve
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

_GTK_FRAME_EXTENTS should be added to _NET_SUPPORTED. Needed by GTK+ 3.16.

src/screen.cpp:
atoms.push_back (Atoms::frameGtkExtents) in CompScreenImpl::_addSupportedAtoms ().

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

> _GTK_FRAME_EXTENTS should be added to _NET_SUPPORTED. Needed by GTK+ 3.16.
>
> src/screen.cpp:
> atoms.push_back (Atoms::frameGtkExtents) in CompScreenImpl::_addSupportedAtoms
> ().

Well, that's needed only by old versions of Gtk (newer one don't really care about that), and yes, will add it but not yet since we still don't handle this value

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

> > _GTK_FRAME_EXTENTS should be added to _NET_SUPPORTED. Needed by GTK+ 3.16.
> >
> > src/screen.cpp:
> > atoms.push_back (Atoms::frameGtkExtents) in
> CompScreenImpl::_addSupportedAtoms
> > ().
>
> Well, that's needed only by old versions of Gtk (newer one don't really care
> about that), and yes, will add it but not yet since we still don't handle this
> value

I think you are wrong. It is needed by GTK+ 3.16. They reverted / added back check for _GTK_FRAME_EXTENTS:
https://git.gnome.org/browse/gtk+/commit/?id=5ced234144ce63decbf5afc8a3517290b9027018

I was testing compiz / gtk-window-decorator with GTK+ 3.16 and windows are not client-side-decorated - they look like compositing manager is not running.

Revision history for this message
MC Return (mc-return) wrote :

This part LGTM, but additional code will be needed also...
(please see my comments here: https://code.launchpad.net/~albertsmuktupavels/compiz/add-gtk-frame-extents-to-net-supported/+merge/257303 )

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches