Compiz

Merge lp://qastaging/~3v1n0/compiz/extents-resize-fixes into lp://qastaging/compiz/0.9.11

extents-resize-fixes
Merge into 0.9.11

Proposed by Marco Trevisan (Treviño) on 2014-02-20

Status:

Merged

Approved by:

Brandon Schaefer on 2014-02-20

Approved revision:

3831

Merged at revision:

3833

Proposed branch:

lp://qastaging/~3v1n0/compiz/extents-resize-fixes

Merge into:

lp://qastaging/compiz/0.9.11

Diff against target:

46 lines (+10/-2)

2 files modified

src/privatewindow.h (+1/-0)
src/window.cpp (+9/-2)

To merge this branch:

bzr merge lp://qastaging/~3v1n0/compiz/extents-resize-fixes

Related bugs:

Bug #1282304: Bottom-edge window placement doesn't take decoration height into consideration	Medium	Fix Released
Bug #1282305: Repeatedly undecorating and redecorating a window shrinks it vertically	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2014-02-20
Brandon Schaefer (community)		2014-02-20	Approve on 2014-02-20
Review via email: mp+207333@code.qastaging.launchpad.net

Commit message

Window: define proper cases when we need to resize a window when decorating/undecorating

Yeah, again here... So, now when setting the window extents, we resize a window only in these cases:
1) We have a normal window that has never been decorated (lp:1282304)
2) We're (re)decorating a maximized or fullscreen window (lp:1282305)

This seems to work well in all the cases I tested, with no regressions with nedit
(that highlighted an issue with old code path)

Description of the change

So, it seems we need to avoid resizing a window when decorating/undecorating it in some cases, while it's needed when creating a new normal window, or it might be go under the bottom edge of the screen.

Revision history for this message