Merge lp://qastaging/~3v1n0/compiz/gtk-decorator-finalize-menu into lp://qastaging/compiz/0.9.11
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Brandon Schaefer |
| Approved revision: | 3793 |
| Merged at revision: | 3792 |
| Proposed branch: | lp://qastaging/~3v1n0/compiz/gtk-decorator-finalize-menu |
| Merge into: | lp://qastaging/compiz/0.9.11 |
| Diff against target: |
101 lines (+16/-16) 3 files modified
gtk/window-decorator/actionmenu.c (+16/-6) gtk/window-decorator/events.c (+0/-8) gtk/window-decorator/wnck.c (+0/-2) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/compiz/gtk-decorator-finalize-menu |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Brandon Schaefer (community) | Approve | ||
|
Review via email:
|
|||
Commit message
ActionMenu: weak ref the action menu on creation, and unref it on destroy
Also, now the widget destruction automatically unset the menu.
This makes the object to be correctly finalized (not only disposed) making sure
the internal idle into WnckActionMenu gets stopped.
Description of the change
Decorator menu was never finalized. A part the leak, this caused also
a crash in the case where the idle that updated its content was fired
just before destroying the related window.
Now we hold a reference and we unref the menu on destroy.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM