Compiz

Merge lp://qastaging/~3v1n0/compiz/scale-hotkeys-change into lp://qastaging/~compiz/compiz/ubuntu

  1. scale-hotkeys-change
  2. Merge into ubuntu
Proposed by Marco Trevisan (Treviño)
Status: Rejected
Rejected by: Sam Spilsbury
Proposed branch: lp://qastaging/~3v1n0/compiz/scale-hotkeys-change
Merge into: lp://qastaging/~compiz/compiz/ubuntu
Diff against target: 51 lines (+15/-5)
2 files modified
debian/changelog (+6/-1)
debian/patches/ubuntu-config.patch (+9/-4)
To merge this branch: bzr merge lp://qastaging/~3v1n0/compiz/scale-hotkeys-change
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Needs Information
Review via email: mp+91112@code.qastaging.launchpad.net

Description of the change

Resubmitting fix for bug #689733 also if that bug is related to launcher icon, actually it affects also the key bindings (also because it mentions the «'Current workspace' spread» that can only be activated using a key shortcut).

Also, according to the document "12.04 Unity shortcuts" http://is.gd/DAHfx0 the Ctrl+W keybinding should be used to scale only the windows in the current workspace.

I've also added the Ctrl+Shift+W keybinding to keep the feature to show all the available windows.

This overrides the merge requested for the ubuntu package at https://code.launchpad.net/~3v1n0/ubuntu/precise/compiz/scale-hotkeys-change/+merge/87797

To post a comment you must log in.
Revision history for this message
Doug McMahon (mc3man) wrote :

Have you tested to see what happens if ctrl+shift+w is used when a firefox window is focused?
Additionally will this return to the user use of any binding for window picker for window group (all workspaces

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Marco, not sure about that one, t seems that there is a small misunderstanding on what the compiz keys are doing (did you test them?):
- initiate_all_key spread the window of the current workspaces, for all monitor (this is the desired behavior and already assigned to ctrl + W)
- initiate_ouptput_key spread the window of the current workspace only on the current monitor. This is not what should be assigned to ctrl + W.

So the current behavior seems to be what's neeed, isn't it?

review: Needs Information

Unmerged revisions

709. By Marco Trevisan (Treviño)

debian/patches/fix-689733.patch:
 - Use Super+W to spread windows of the current workspace (LP: #689733)
 - Set Super+Shift+W to spread all the open windows

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches