GTK+

Merge lp://qastaging/~3v1n0/gtk/unity-border-radius-support into lp://qastaging/~ubuntu-desktop/gtk/ubuntugtk3

unity-border-radius-support
Merge into ubuntugtk3

Proposed by Marco Trevisan (Treviño) on 2016-03-07

Status:

Merged

Approved by:

Sebastien Bacher on 2016-03-18

Approved revision:

511

Merged at revision:

509

Proposed branch:

lp://qastaging/~3v1n0/gtk/unity-border-radius-support

Merge into:

lp://qastaging/~ubuntu-desktop/gtk/ubuntugtk3

Diff against target:

363 lines (+279/-56)

4 files modified

debian/changelog (+9/-0)
debian/patches/series (+1/-1)
debian/patches/unity-border-radius.patch (+269/-0)
debian/patches/unity_rbga_tooltips.patch (+0/-55)

To merge this branch:

bzr merge lp://qastaging/~3v1n0/gtk/unity-border-radius-support

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Sebastien Bacher	2016-03-07	Approve on 2016-03-18
desrt (community)		Needs Fixing on 2016-03-17
Review via email: mp+288331@code.qastaging.launchpad.net

Description of the change

Export windows corners radius as an X11 property in unity.

It works together with lp:~3v1n0/unity/gtk-border-radius-support/+merge/288358

lp://qastaging/~3v1n0/gtk/unity-border-radius-support updated on 2016-03-10

505. By Marco Trevisan (Treviño) on 2016-03-08: debian/patches/unity-border-radius.patch: Export windows corners radius as an X11 property in unity
506. By Marco Trevisan (Treviño) on 2016-03-10: debian/patches/unity-border-radius.patch:
- Don't draw window border in unity for any theme. Add unity-csd style class.
507. By Marco Trevisan (Treviño) on 2016-03-10: Merging with lp:~ubuntu-desktop/gtk/ubuntugtk3

Revision history for this message

desrt (desrt) wrote on 2016-03-15:

Looks pretty good, but there are some things that I would consider changing.

I am not an expert in GTK theming by any measure, however, so my suggestions might be pure insanity. I just took a look at how some other widgets are doing things.

One comment in general: do we really need to query the title widget to find out the borders that will be drawn on the toplevel? Something seems wrong here. I would have expected that we can query this information directly from the window itself in some way (and avoid the ugly hacks about assuming zeros).

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2016-03-15:

> One comment in general: do we really need to query the title widget to find
> out the borders that will be drawn on the toplevel? Something seems wrong
> here. I would have expected that we can query this information directly from
> the window itself in some way (and avoid the ugly hacks about assuming zeros).

Not as far I know... The window itself has not rounded corners, but it can have a titlebox which has rounded corners.
By defining a border-radius to the window itself, gives no rounded corners by default. It might be something that will work in the future, though. But not right now AFAIK.

To remove the workaround we could get these values from the toplevel, and in case a titlebox is defined we get them from that, but we can't query them from the toplevel, from what I see.

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) on 2016-03-15:

Revision history for this message

desrt (desrt) on 2016-03-15:

lp://qastaging/~3v1n0/gtk/unity-border-radius-support updated on 2016-03-15

508. By Marco Trevisan (Treviño) on 2016-03-15

debian/patches/unity-border-radius.patch:
  - use better style
  - take care of window scaling (and update values on scale changes)
  - use memcmp instead of manual checks
  - only check changes if border radius properties changed (using "style-updated" signal)
  - remove unwanted change

509. By Marco Trevisan (Treviño) on 2016-03-15