Merge lp://qastaging/~3v1n0/indicator-sound/gtk-application-player-activate into lp://qastaging/indicator-sound/13.10

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Lars Karlitski
Approved revision: 347
Merged at revision: 346
Proposed branch: lp://qastaging/~3v1n0/indicator-sound/gtk-application-player-activate
Merge into: lp://qastaging/indicator-sound/13.10
Prerequisite: lp://qastaging/~3v1n0/indicator-sound/launch-context
Diff against target: 191 lines (+131/-4)
5 files modified
src/Makefile.am (+2/-1)
src/gtk-application-player.vala (+123/-0)
src/metadata-menu-item.vala (+2/-1)
src/mpris2-controller.vala (+2/-2)
src/player-controller.vala (+2/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/indicator-sound/gtk-application-player-activate
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Lars Karlitski (community) Approve
Review via email: mp+157358@code.qastaging.launchpad.net

Commit message

PlayerController use GtkApplicationPlayer and activate it when we need to raise

GtkApplicationPlayer: add a class to handle the GtkApplication players
It allows to check if the given player implements the "org.gtk.Application" interface
and if it's the case, it Activate the application with the proper timestamp when
requested.

Description of the change

Upstream port for lp:~3v1n0/indicator-sound/gtk-application-player-activate/+merge/156919

Add a GtkApplicationPlayer utility class used to check if a player application supports the "org.gtk.Application" dbus interface, and in case it sends the platform_data with activation timestamp to it when raising it.

This fixes bug #627195 for some applications such as Rhythmbox.
Unfortunately the proper fix would need to change the MPRIS interface. See https://bugs.launchpad.net/ayatana-design/+bug/627195/comments/26

To post a comment you must log in.
Revision history for this message
Lars Karlitski (larsu) wrote :

Approved, same as the one merged in 13.04.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Unity Merger (unity-merger) wrote :

No proposals found for merge of lp:~3v1n0/indicator-sound/launch-context into lp:indicator-sound.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches