Merge lp://qastaging/~3v1n0/indicator-sound/launch-context into lp://qastaging/indicator-sound/13.04
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Mathieu Trudel-Lapierre |
| Approved revision: | 345 |
| Merged at revision: | 345 |
| Proposed branch: | lp://qastaging/~3v1n0/indicator-sound/launch-context |
| Merge into: | lp://qastaging/indicator-sound/13.04 |
| Diff against target: |
105 lines (+18/-8) 6 files modified
src/Makefile.am (+1/-0) src/metadata-menu-item.vala (+6/-3) src/mpris2-controller.vala (+1/-1) src/player-controller.vala (+5/-2) src/sound-service.c (+1/-1) src/transport-menu-item.vala (+4/-1) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/indicator-sound/launch-context |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Mathieu Trudel-Lapierre | Approve | ||
|
Review via email:
|
|||
Commit message
MenuItem: use GtkLaunchContext with proper event timeout to launch applications
Also discards non-activation events
Description of the change
Like all the launcher applications, also indicator-sound should properly use the GAppLaunchContext when launching an application. Changed the code to use the event timestamp of the click action with the GtkAppLaunchCon
This will allow to make indicator-sound to work nicely with the compiz focus prevention mechanism.
In handle_event calls we also need to ignore the non-activation events.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:345
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://