Merge lp://qastaging/~3v1n0/indicator-sound/mute-on-secondary-activate into lp://qastaging/indicator-sound/fourth
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Merged at revision: | 254 |
| Proposed branch: | lp://qastaging/~3v1n0/indicator-sound/mute-on-secondary-activate |
| Merge into: | lp://qastaging/indicator-sound/fourth |
| Prerequisite: | lp://qastaging/~3v1n0/indicator-sound/compile-with-new-API |
| Diff against target: |
367 lines (+269/-0) 5 files modified
src/Makefile.am (+2/-0) src/indicator-sound.c (+54/-0) src/mute-menu-item.c (+5/-0) src/mute-widget.c (+141/-0) src/mute-widget.h (+67/-0) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/indicator-sound/mute-on-secondary-activate |
| Related bugs: | |
| Related blueprints: |
Desktop DX Indicators Review
(Undefined)
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Conor Curran (community) | Approve | ||
| Indicator Applet Developers | Pending | ||
|
Review via email:
|
|||
Description of the change
When the "secondary-
This branch performs this using a new mute-widget that is used by indicator-sound to control the mute-menu-item dbus menuitem.
The code needs the libindicator support (available in lp:~3v1n0/libindicator/secondary-activate-support) and unity/unity-2d support (available in lp:~3v1n0/unity/secondary-activate-support and in lp:~3v1n0/unity-2d/secondary-activate-support)
To post a comment you must log in.
Revision history for this message
| Conor Curran (cjcurran) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
