Merge lp://qastaging/~3v1n0/indicator-sound/scroll-api-merge into lp://qastaging/indicator-sound/fourth

Proposed by Marco Trevisan (Treviño)
Status: Merged
Merge reported by: Conor Curran
Merged at revision: not available
Proposed branch: lp://qastaging/~3v1n0/indicator-sound/scroll-api-merge
Merge into: lp://qastaging/indicator-sound/fourth
Diff against target: 92 lines (+22/-16)
2 files modified
configure.ac (+17/-11)
src/indicator-sound.c (+5/-5)
To merge this branch: bzr merge lp://qastaging/~3v1n0/indicator-sound/scroll-api-merge
Reviewer Review Type Date Requested Status
Conor Curran (community) Approve
Review via email: mp+66677@code.qastaging.launchpad.net

Description of the change

Use the "entry-scrolled" signal instead of the old one.
It follows the API changes of libindicator, See related bug #804618 for more informations.
Plus fixed the compilation with GTK-2.

It needs the merge of lp:~3v1n0/libindicator/scroll-api-merge

To post a comment you must log in.
Revision history for this message
Conor Curran (cjcurran) wrote :

Thanks Trevino, will merge in and release for Thursday.

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Nice, however before merging it, wait for the merge of lp:~3v1n0/libindicator/scroll-api-merge too (otherwise it won't compile :P).

Revision history for this message
Conor Curran (cjcurran) wrote :

will do.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ok, that libindicator branch is now merged, you can proceed with indicator-sound too :)

Revision history for this message
Conor Curran (cjcurran) :
review: Approve
Revision history for this message
Conor Curran (cjcurran) wrote :

On hold until the new libindicator is released.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches