libappindicator

Merge lp://qastaging/~3v1n0/libappindicator/secondary-activate-support into lp://qastaging/libappindicator

  1. secondary-activate-support
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Merged at revision: 212
Proposed branch: lp://qastaging/~3v1n0/libappindicator/secondary-activate-support
Merge into: lp://qastaging/libappindicator
Diff against target: 590 lines (+232/-64)
8 files modified
bindings/mono/examples/IndicatorExample.cs (+8/-1)
bindings/vala/examples/indicator-example.vala (+3/-2)
example/simple-client-vala.vala (+12/-1)
example/simple-client.c (+55/-54)
src/app-indicator.c (+146/-6)
src/app-indicator.h (+3/-0)
src/application-service-marshal.list (+1/-0)
src/notification-item.xml (+4/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/libappindicator/secondary-activate-support
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Indicator Applet Developers Pending
Review via email: mp+68407@code.qastaging.launchpad.net

Description of the change

Add support to "secondary-activate" event support for libappindicator based applications, as described in bug #812933.

This needs the merge of lp:~3v1n0/indicator-application/secondary-activate-support and unity and unity-2d support (available in lp:~3v1n0/unity/secondary-activate-support and in lp:~3v1n0/unity-2d/secondary-activate-support).

It includes the support for fallback indicators (tray icons).

To post a comment you must log in.
lp://qastaging/~3v1n0/libappindicator/secondary-activate-support updated
214. By Marco Trevisan (Treviño)

Call the right signal on middle-click over the tray icon!

215. By Marco Trevisan (Treviño)

app-indicator: Move from "secondary-activate" signal to secondary_activate target

To avoid appindicators writers to use the "secondary-activate"
event to perform actions that can't be done via a menu item
we added a new API:

 - app_indicator_set_secondary_activate_target
 - app_indicator_get_secondary_activate_target

With it, an appindicator writer can simply define a new GtkWidget
that will be activated when a secondary activation will occur.
The GtkWidget must be a sensitive and visible inner child of
the appindicator MenuItem.

216. By Marco Trevisan (Treviño)

mono bindings: updated API and example

217. By Marco Trevisan (Treviño)

vala: updated example to use the new API

218. By Marco Trevisan (Treviño)

examples: use the set_secondary_activate_target API

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ok, I've updated the branch using the new APIs, read more in the changelog, but basically now it's possible to assign a menu child as the item to be activated on middle-click.

And that's possible only if the menu-item is visible and sensitive.

Revision history for this message
Ted Gould (ted) wrote :

Very cool. One small change in app_indicator_set_secondary_activate_target where it should disconnect the menuitem no matter if the input is NULL or a new value otherwise we keep a ref. I'll fix it on the merge.

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Oh, yes... That's true, sorry I forgot that.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches