Merge lp://qastaging/~3v1n0/libindicator/secondary-activate-support into lp://qastaging/libindicator/0.4

Proposed by Marco Trevisan (Treviño)
Status: Merged
Merged at revision: 426
Proposed branch: lp://qastaging/~3v1n0/libindicator/secondary-activate-support
Merge into: lp://qastaging/libindicator/0.4
Diff against target: 94 lines (+27/-3)
3 files modified
libindicator/indicator-object-marshal.list (+1/-0)
libindicator/indicator-object.c (+22/-2)
libindicator/indicator-object.h (+4/-1)
To merge this branch: bzr merge lp://qastaging/~3v1n0/libindicator/secondary-activate-support
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+68393@code.qastaging.launchpad.net

Description of the change

Add support to "secondary-activate" event, needed by both bug #609860 and bug #812933. See the latest for more informations.

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

It seems to me that there isn't a reason we need the X and Y information. The only reason that'd be useful is to present a menu, which is something we don't want people to do.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

I've explained the reason in the bug report, the fact is that the StatusNotifierItem SecondaryActivate method needs these values [1], and I export them to follow that specification.

[1] http://www.notmart.org/misc/statusnotifieritem/statusnotifieritem.html#SecondaryActivate

Revision history for this message
Ted Gould (ted) wrote :

While, in general, I think that we should work towards matching the SNI spec, I think that this is an exception. The behavior that we're going to get is applications that use this signal in a way that we're not comfortable with will work poorly on Ubuntu and ruin the overall experience. We have no way to detect what the application is going to do with the signal, so we must error on the side of not sending it.

Revision history for this message
Ted Gould (ted) wrote :

To be clear, in libappindicator we can accept it an use it like the other signals. But we should not send it from indicator-application.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

In libappindicator we're not using a signal anymore... In indicator-application we're using that value for sending the right SecondaryActivate method, I guess it's needed by non-ubuntu indicators (for kde apps ones?)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches