libindicator

Merge lp://qastaging/~3v1n0/libindicator/use-gappinfo-commandline into lp://qastaging/libindicator/13.10

  1. use-gappinfo-commandline
  2. Merge into trunk.13.10
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Ted Gould
Approved revision: 489
Merged at revision: 491
Proposed branch: lp://qastaging/~3v1n0/libindicator/use-gappinfo-commandline
Merge into: lp://qastaging/libindicator/13.10
Diff against target: 62 lines (+12/-24)
1 file modified
libindicator/indicator-desktop-shortcuts.c (+12/-24)
To merge this branch: bzr merge lp://qastaging/~3v1n0/libindicator/use-gappinfo-commandline
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ted Gould (community) Approve
Review via email: mp+158569@code.qastaging.launchpad.net

Commit message

IndicatorDesktopShortcuts: Use the proper way to create an AppInfo from command-line

Removed the hack that we used to create a .desktop app-info from a locally
generated keyfile, using g_app_info_create_from_commandline instead.

Description of the change

We currently generate the GAppInfo to launch the shortcuts using an hack by generating a fake .desktop key-file in memory and then building an AppInfo from it. This is not needed, since g_app_info_create_from_commandline can do everything that we need in a cleaner way.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:487
http://jenkins.qa.ubuntu.com/job/libindicator-ci/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-raring-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-raring-armhf-ci/4

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/4/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:488
http://jenkins.qa.ubuntu.com/job/libindicator-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-raring-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-raring-armhf-ci/6

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/6/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:489
http://jenkins.qa.ubuntu.com/job/libindicator-ci/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-raring-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-raring-armhf-ci/8

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/8/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/libindicator-autolanding/4/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-autolanding/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-autolanding/2/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches