Nux

Merge lp://qastaging/~3v1n0/nux/cancellable-ibus into lp://qastaging/nux

  1. cancellable-ibus
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 826
Merged at revision: 819
Proposed branch: lp://qastaging/~3v1n0/nux/cancellable-ibus
Merge into: lp://qastaging/nux
Diff against target: 307 lines (+69/-66)
2 files modified
Nux/InputMethodIBus.cpp (+68/-66)
Nux/InputMethodIBus.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/nux/cancellable-ibus
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+187813@code.qastaging.launchpad.net

Commit message

InputMethodIBus: use GCancellable to ignore callback events after destruction

Also use nux logger and add some code cleanup

Description of the change

This will finally fixes the test-gtest crashes in unity when running ibus

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:825
http://jenkins.qa.ubuntu.com/job/nux-ci/74/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-saucy-amd64-ci/26
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-saucy-armhf-ci/26
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-saucy-i386-ci/26

Click here to trigger a rebuild:
http://s-jenkins:8080/job/nux-ci/74/rebuild

review: Approve (continuous-integration)
lp://qastaging/~3v1n0/nux/cancellable-ibus updated
826. By Marco Trevisan (Treviño)

InputMethodIBus: process the key event natevely only if ibus didn't handle that

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Cool LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches