Merge lp://qastaging/~3v1n0/nux/displayx11-atoms-cache into lp://qastaging/nux
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Brandon Schaefer |
| Approved revision: | 822 |
| Merged at revision: | 803 |
| Proposed branch: | lp://qastaging/~3v1n0/nux/displayx11-atoms-cache |
| Merge into: | lp://qastaging/nux |
| Prerequisite: | lp://qastaging/~3v1n0/nux/memory-fixes |
| Diff against target: |
406 lines (+119/-52) 2 files modified
NuxGraphics/GraphicsDisplayX11.cpp (+116/-52) NuxGraphics/XInputWindow.cpp (+3/-0) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/nux/displayx11-atoms-cache |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Brandon Schaefer (community) | Approve | ||
|
Review via email:
|
|||
Commit message
GraphicsDisplayX11: cache the atom values, calling the slow XInternAtom just once per each
Description of the change
No need to call the sync XInternAtom call everytime for the same values, we can cache these values improving speed and without wasting memory.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM