Nux

Merge lp://qastaging/~3v1n0/nux/text-entry-compose-ignore-modifiers into lp://qastaging/nux

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 661
Merged at revision: 629
Proposed branch: lp://qastaging/~3v1n0/nux/text-entry-compose-ignore-modifiers
Merge into: lp://qastaging/nux
Diff against target: 458 lines (+144/-63)
2 files modified
Nux/TextEntry.cpp (+37/-4)
tests/gtest-nux-textentry.cpp (+107/-59)
To merge this branch: bzr merge lp://qastaging/~3v1n0/nux/text-entry-compose-ignore-modifiers
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+113323@code.qastaging.launchpad.net

Commit message

TextEntry: ignore meta keypresses when in composition mode

Description of the change

When in composition mode any pressure of a modifier key (such as AltGr) should be ignored, so that it's possible to continue to compose a correct char.

Tests covered by gtest.

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches