Merge lp://qastaging/~3v1n0/nux/text-entry-improved-sequencies into lp://qastaging/nux
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Brandon Schaefer | ||||
| Approved revision: | 673 | ||||
| Merged at revision: | 633 | ||||
| Proposed branch: | lp://qastaging/~3v1n0/nux/text-entry-improved-sequencies | ||||
| Merge into: | lp://qastaging/nux | ||||
| Prerequisite: | lp://qastaging/~3v1n0/nux/text-entry-double-deadkeys-fix | ||||
| Diff against target: |
1945 lines (+1462/-363) 4 files modified
Nux/TextEntry.cpp (+4/-4) Nux/TextEntryComposeSeqs.h (+1224/-354) tests/gtest-nux-textentry.cpp (+65/-5) tools/compose_key_list_generator.py (+169/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/nux/text-entry-improved-sequencies | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brandon Schaefer (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2012-07-06.
Commit message
TextEntryCompos
List based on:
http://
Updated also the dead_keys_map with valid values and updated to char*
Description of the change
Added a tool python script to generate char sequences from sources like [1], then used its output to update the nux TextEntry ComposeSeq file.
Updated also the dead_keys_map with fixed characters and converted to char* as we need utf-8 support too.
Now you can write "I ♥ " in the dash (basically a blocker! ☺)!
Tests updated and added for changed code.
[1] http://
| Unity Merger (unity-merger) wrote | # |
Awesome!! All test pass, manually working, code looks good (+2 for being up to date with any changes that go into compose now!) also another +1 for Ubuntu !