Merge lp://qastaging/~3v1n0/nux/xinputwindow-cache-atoms into lp://qastaging/nux
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Andrea Azzarone |
| Approved revision: | 800 |
| Merged at revision: | 796 |
| Proposed branch: | lp://qastaging/~3v1n0/nux/xinputwindow-cache-atoms |
| Merge into: | lp://qastaging/nux |
| Prerequisite: | lp://qastaging/~3v1n0/nux/autoreconf-doxygen-fix |
| Diff against target: |
210 lines (+61/-54) 2 files modified
NuxGraphics/XInputWindow.cpp (+61/-53) NuxGraphics/XInputWindow.h (+0/-1) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/nux/xinputwindow-cache-atoms |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Andrea Azzarone (community) | Approve | ||
|
Review via email:
|
|||
Commit message
XinputWindow: cache the X Atoms we use for all the nux windows
This reduces the time to create a window, as we call XInternAtom just once
Description of the change
For each atom we use in Nux XInputWindow we always call the slow XInternAtom, while we can safely cache these values for all the windows we create reducing the initialization time.
To post a comment you must log in.
Revision history for this message
| Andrea Azzarone (azzar1) | # |
review:
Approve
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:799
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://