Merge lp://qastaging/~3v1n0/u1db-qt/doc-path-change-fixes into lp://qastaging/u1db-qt

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Cris Dywan
Approved revision: 128
Merged at revision: 129
Proposed branch: lp://qastaging/~3v1n0/u1db-qt/doc-path-change-fixes
Merge into: lp://qastaging/u1db-qt
Prerequisite: lp://qastaging/~3v1n0/u1db-qt/uri-path-parsing
Diff against target: 155 lines (+26/-13)
9 files modified
examples/u1db-qt-example-1/u1db-qt-example-1.qml (+1/-1)
examples/u1db-qt-example-2/u1db-qt-example-2.qml (+1/-1)
examples/u1db-qt-example-2b/u1db-qt-example-2b.qml (+1/-1)
examples/u1db-qt-example-3/u1db-qt-example-3.qml (+1/-1)
examples/u1db-qt-example-5/u1db-qt-example-5.qml (+1/-1)
examples/u1db-qt-example-6/u1db-qt-example-6.qml (+2/-5)
src/document.cpp (+16/-0)
src/index.cpp (+1/-0)
tests/tst_database.qml (+2/-3)
To merge this branch: bzr merge lp://qastaging/~3v1n0/u1db-qt/doc-path-change-fixes
Reviewer Review Type Date Requested Status
Cris Dywan Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+251439@code.qastaging.launchpad.net

Commit message

Document: ensure defaults and contents are set when database path changes

Description of the change

When database path changes (as it happens when you use a JS call to set it), document does not initialize defaults and contents correctly on it.

To post a comment you must log in.
126. By Marco Trevisan (Treviño)

Document: put current contents on database when path changes and new one is empty

127. By Marco Trevisan (Treviño)

Examples: use Qt.resolvedUrl to open databases

In this way we won't put settings inside user config

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
128. By Marco Trevisan (Treviño)

Fix tests

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

That's a nice fix. I didn't even realize before that the unit tests hint at this very bug.

review: Approve
129. By Marco Trevisan (Treviño)

Index: ensure we've the index set on db when path changes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: