Merge lp://qastaging/~3v1n0/ubuntu-themes/cosmic-fixes into lp://qastaging/ubuntu-themes

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 635
Merged at revision: 627
Proposed branch: lp://qastaging/~3v1n0/ubuntu-themes/cosmic-fixes
Merge into: lp://qastaging/ubuntu-themes
Diff against target: 368 lines (+154/-16)
9 files modified
Ambiance/gtk-3.20/apps/chromium.css (+4/-0)
Ambiance/gtk-3.20/apps/gnome-boxes.css (+10/-1)
Ambiance/gtk-3.20/gtk-main.css (+1/-0)
Ambiance/gtk-3.20/gtk-widgets.css (+49/-6)
Radiance/gtk-3.20/apps/chromium.css (+4/-0)
Radiance/gtk-3.20/apps/gnome-boxes.css (+10/-1)
Radiance/gtk-3.20/gtk-main.css (+1/-0)
Radiance/gtk-3.20/gtk-widgets.css (+51/-8)
debian/changelog (+24/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/ubuntu-themes/cosmic-fixes
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+356072@code.qastaging.launchpad.net

Commit message

Ambiance, Radiance: improve theming as per bionic reviews and bug reports

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

> Ambiance, Radiance: use default disabled color for actions headerbar buttons (LP: #1743373)

The bug number seems incorrect. Can you please fix this and also link the bug to the MR?

Revision history for this message
Andrea Azzarone (azzar1) wrote :

Once fixed it looks good to me.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Thanks for spotting, fixed now.

Actual bug I wanted to link was https://launchpad.net/bugs/1785699

635. By Marco Trevisan (Treviño)

debian/changelog: sync with bzr changes

636. By Marco Trevisan (Treviño)

Radiance: Use scaled image for buttons border

Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches