Merge lp://qastaging/~3v1n0/ubuntu/oneiric/nautilus/progress-indicator-support into lp://qastaging/ubuntu/oneiric/nautilus
Status: | Work in progress |
---|---|
Proposed branch: | lp://qastaging/~3v1n0/ubuntu/oneiric/nautilus/progress-indicator-support |
Merge into: | lp://qastaging/ubuntu/oneiric/nautilus |
Diff against target: |
3381 lines (+1493/-1007) 28 files modified
.pc/11_copy_skipping_pager.patch/src/nautilus-progress-ui-handler.c (+101/-5) .pc/applied-patches (+1/-0) Makefile.in (+2/-0) aclocal.m4 (+805/-803) config.h.in (+3/-0) configure (+186/-20) configure.in (+25/-0) cut-n-paste-code/Makefile.in (+2/-0) cut-n-paste-code/libegg/Makefile.in (+2/-0) data/Makefile.in (+2/-0) data/icons/Makefile.in (+2/-0) data/nautilus.desktop.in (+1/-1) debian/changelog (+8/-0) debian/patches/07_use_application_indicator.patch (+215/-164) debian/patches/11_copy_skipping_pager.patch (+4/-4) debian/patches/series (+1/-1) docs/Makefile.in (+2/-0) docs/reference/Makefile.in (+2/-0) docs/reference/libnautilus-extension/Makefile.in (+2/-0) eel/Makefile.in (+2/-0) icons/Makefile.in (+2/-0) libnautilus-extension/Makefile.in (+2/-0) libnautilus-private/Makefile.in (+2/-0) nautilus-sendto-extension/Makefile.in (+2/-0) src/Makefile.am (+2/-0) src/Makefile.in (+12/-4) src/nautilus-progress-ui-handler.c (+101/-5) test/Makefile.in (+2/-0) |
To merge this branch: | bzr merge lp://qastaging/~3v1n0/ubuntu/oneiric/nautilus/progress-indicator-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Matthew Paul Thomas (community) | design | Disapprove | |
Ubuntu branches | Pending | ||
Review via email:
|
Description of the change
Added back the indicator support for the nautilus progress window, now it also shows on middle-click (indicator secondary activate) and it shows in a disabled menuitem the progress informations.
Actually the indicator is shown only when the progress window has been closed, I'd suggest to show it everytime that the transfer window loses its focus, since sometimes it goes behind a focused window and it's easily lost.
A future improvement could also to show always just an indicator with a progress-bar instead of a floating window.
Unmerged revisions
- 237. By Marco Trevisan (Treviño)
-
Use Application Indicator patch updated
Updated the patch to work with current code, plus added the support
for showing the progress dialog on middle-click (secondary activate)
and a nautilus progress menu item information.
I'd rather show the progress on the unity launcher icon, looks more representative of what a "progress" is, and it's in line with other progress meters shown on the launcher (firefox downloads, transmission etc etc...).