Merge lp://qastaging/~3v1n0/ubuntu/oneiric/nautilus/progress-indicator-support into lp://qastaging/ubuntu/oneiric/nautilus

Proposed by Marco Trevisan (Treviño)
Status: Work in progress
Proposed branch: lp://qastaging/~3v1n0/ubuntu/oneiric/nautilus/progress-indicator-support
Merge into: lp://qastaging/ubuntu/oneiric/nautilus
Diff against target: 3381 lines (+1493/-1007)
28 files modified
.pc/11_copy_skipping_pager.patch/src/nautilus-progress-ui-handler.c (+101/-5)
.pc/applied-patches (+1/-0)
Makefile.in (+2/-0)
aclocal.m4 (+805/-803)
config.h.in (+3/-0)
configure (+186/-20)
configure.in (+25/-0)
cut-n-paste-code/Makefile.in (+2/-0)
cut-n-paste-code/libegg/Makefile.in (+2/-0)
data/Makefile.in (+2/-0)
data/icons/Makefile.in (+2/-0)
data/nautilus.desktop.in (+1/-1)
debian/changelog (+8/-0)
debian/patches/07_use_application_indicator.patch (+215/-164)
debian/patches/11_copy_skipping_pager.patch (+4/-4)
debian/patches/series (+1/-1)
docs/Makefile.in (+2/-0)
docs/reference/Makefile.in (+2/-0)
docs/reference/libnautilus-extension/Makefile.in (+2/-0)
eel/Makefile.in (+2/-0)
icons/Makefile.in (+2/-0)
libnautilus-extension/Makefile.in (+2/-0)
libnautilus-private/Makefile.in (+2/-0)
nautilus-sendto-extension/Makefile.in (+2/-0)
src/Makefile.am (+2/-0)
src/Makefile.in (+12/-4)
src/nautilus-progress-ui-handler.c (+101/-5)
test/Makefile.in (+2/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/ubuntu/oneiric/nautilus/progress-indicator-support
Reviewer Review Type Date Requested Status
Matthew Paul Thomas (community) design Disapprove
Ubuntu branches Pending
Review via email: mp+70645@code.qastaging.launchpad.net

Description of the change

Added back the indicator support for the nautilus progress window, now it also shows on middle-click (indicator secondary activate) and it shows in a disabled menuitem the progress informations.

Actually the indicator is shown only when the progress window has been closed, I'd suggest to show it everytime that the transfer window loses its focus, since sometimes it goes behind a focused window and it's easily lost.

A future improvement could also to show always just an indicator with a progress-bar instead of a floating window.

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) wrote :

I'd rather show the progress on the unity launcher icon, looks more representative of what a "progress" is, and it's in line with other progress meters shown on the launcher (firefox downloads, transmission etc etc...).

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Yes, you're right... It's the same thing I was thinking. However before doing that I preferred to update the app-indicator patch... Also, using an unity progressbar, wouldn't inform about the different progresses, but this could be easily solved by showing also the number of the transfers over the icon plus a quicklist item to bring the progress window on top in the case you want to see more accurate informations.

I'll give a look to it as soon as I can.

Revision history for this message
Omer Akram (om26er) wrote :

try to propose it to lp:~ubuntu-desktop/nautilus/ubuntu I think the large diff might get fixed by doing that. Might be better to talk to MPT before re-enabling the indicator IIRC there was a debate before to remove the indicator

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

The large diff is just caused by the fact that I also applied the patch (as all the other ones are), so the stack needs to be updated accordingly I guess.

About the design, I'm waiting an answer from mpt or others, but I'm leaving in few days so I don't know if I'll be able to finish this.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Nautilus's progress window is closable even when the task has not completed. This is misleading, because it's not clear whether closing it stops or cancels the task (it does neither). It is also unnecessary, because the window is temporary and can be hidden by minimizing. The problem could easily have been fixed by making the window uncloseable, but back then applications couldn't rely on window managers following instructions.

So instead of doing that, someone added a notification area item to reopen the progress window. This did not solve the original problem, except for people who both noticed and understood the presence of the notification area item.

Then when the notification area was retired, someone reimplemented the notification area item as an application indicator. This still did not solve the problem, except for people who both noticed and understood the presence of the menu. (I am partly to blame here, because I never found time to fill in the "nautilus" item in <https://wiki.ubuntu.com/NotificationAreaTransition/CompatibilityFixes>.)

And now this branch re-adds the application indicator, while <https://code.launchpad.net/~3v1n0/ubuntu/oneiric/nautilus/unity-launcher-support/+merge/70685> adds a "Show Progress Window" quicklist item.

There really is no point in having two different ways to hide a temporary window, and two different ways to show it, where there is no difference in memory consumption, taskbar real estate, or anything else, and (worst of all) what you need to do to show the window depends on how you hid it. So please, let's just fix the root problem -- make the window uncloseable. Thanks. :-)

review: Disapprove (design)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for your work, do you think you could rather go in the way mpt suggested there?

Revision history for this message
Sebastien Bacher (seb128) wrote :

hey Marco, do you still want to work on that?

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Sorry Sebastien, I didn't continue to work on this since I'm just back from 15 days of holidays (where I haven't my PC with me), however this work has actually been merged in nautilus including the unity support (see https://code.launchpad.net/~3v1n0/ubuntu/oneiric/nautilus/unity-launcher-support/+merge/70685).

I guess, however, that I should revert this indicator support from the merged patch.

Unmerged revisions

237. By Marco Trevisan (Treviño)

Use Application Indicator patch updated

Updated the patch to work with current code, plus added the support
for showing the progress dialog on middle-click (secondary activate)
and a nautilus progress menu item information.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches