Merge lp://qastaging/~3v1n0/unity-2d/fix-multiscreen-indicators-geometries into lp://qastaging/unity-2d
Proposed by
Marco Trevisan (Treviño)
Status: | Merged |
---|---|
Approved by: | Alberto Mardegan |
Approved revision: | 758 |
Merged at revision: | 759 |
Proposed branch: | lp://qastaging/~3v1n0/unity-2d/fix-multiscreen-indicators-geometries |
Merge into: | lp://qastaging/unity-2d |
Diff against target: |
109 lines (+26/-6) 4 files modified
libunity-2d-private/src/indicatorsmanager.cpp (+10/-2) libunity-2d-private/src/indicatorsmanager.h (+4/-1) libunity-2d-private/src/unity2dpanel.cpp (+10/-3) libunity-2d-private/src/unity2dpanel.h (+2/-0) |
To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity-2d/fix-multiscreen-indicators-geometries |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Mardegan (community) | Approve | ||
Review via email: mp+78965@code.qastaging.launchpad.net |
Description of the change
Fixing bug #869196 for unity-2d as well, making each panel-window to sync his indicator geometries sending a different panel-id to unity-panel-
The code has a "soft" dependency with the latest unity-panel-
To post a comment you must log in.
Hi Marco, excellent work! I will test it soon, just looking at the code for now :-)
Meanwhile, a couple of comments:
- Making the Unity2dPanel as implicit parent for the IndicatorsManager can cause confusion. For instance, one could call IndicatorsManag er::setParent( ) and break our assumption. IMHO it's better to have a separate method IndicatorsManag er::setPanel( ), or a constructor which takes both a Unity2dPanel argument and a parent QObject.
- Member naming: getID() -> id()
- "d->q" = "this" :-)