Merge lp://qastaging/~3v1n0/unity-2d/secondary-activate-support into lp://qastaging/unity-2d/3.0

Proposed by Marco Trevisan (Treviño)
Status: Rejected
Rejected by: Florian Boucault
Proposed branch: lp://qastaging/~3v1n0/unity-2d/secondary-activate-support
Merge into: lp://qastaging/unity-2d/3.0
Prerequisite: lp://qastaging/~3v1n0/unity-2d/scroll-api-merge
Diff against target: 123 lines (+44/-11)
3 files modified
libunity-2d-private/Unity2d/CMakeLists.txt (+1/-1)
panel/applets/CMakeLists.txt (+3/-3)
panel/applets/indicator/indicator.c (+40/-7)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity-2d/secondary-activate-support
Reviewer Review Type Date Requested Status
Aurélien Gâteau (community) Disapprove
Review via email: mp+68395@code.qastaging.launchpad.net

Description of the change

Add support to "secondary-activate" event on middle-click, needed both by bug #609860 and bug #812933. See the second for more informations.

This needs the merge of lp:~3v1n0/libindicator/secondary-activate-support

To post a comment you must log in.
621. By Marco Trevisan (Treviño)

Merging with upstream...

622. By Marco Trevisan (Treviño)

libindicator doesn't support x,y mouse position anymore.

Dropping them from signal.

Revision history for this message
Aurélien Gâteau (agateau) wrote :

Unfortunately this branch cannot be merged in for the same reason lp:~3v1n0/unity-2d/scroll-api-merge cannot be (cf. https://code.launchpad.net/~3v1n0/unity-2d/scroll-api-merge/+merge/66680 )

review: Disapprove

Unmerged revisions

622. By Marco Trevisan (Treviño)

libindicator doesn't support x,y mouse position anymore.

Dropping them from signal.

621. By Marco Trevisan (Treviño)

Merging with upstream...

620. By Marco Trevisan (Treviño)

Use gtk_widget_get_allocation for better future Gtk3 support

619. By Marco Trevisan (Treviño)

Emit secondary_activate signal on Middle-Click over indicators

When a middle-click is performed (press and release over the same indicator)
emit the "secondary-activate" signal to the hit indicator entry.

This can be used by indicators to perform particular actions.

618. By Marco Trevisan (Treviño)

Compile with libindicator-0.4

617. By Marco Trevisan (Treviño)

Use the "entry-scrolled" signal instead of the old ones

It follows the API change of libindicator

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches