Unity Settings Daemon

Merge lp://qastaging/~3v1n0/unity-settings-daemon/keep-cached-kbd-backlight-updated into lp://qastaging/unity-settings-daemon

  1. keep-cached-kbd-backlight-updated
  2. Merge into trunk
Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 4136
Merged at revision: 4136
Proposed branch: lp://qastaging/~3v1n0/unity-settings-daemon/keep-cached-kbd-backlight-updated
Merge into: lp://qastaging/unity-settings-daemon
Prerequisite: lp://qastaging/~seb128/unity-settings-daemon/better-keyboard-backlight
Diff against target: 83 lines (+28/-3)
1 file modified
plugins/power/gsd-power-manager.c (+28/-3)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity-settings-daemon/keep-cached-kbd-backlight-updated
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+294662@code.qastaging.launchpad.net

Commit message

PowerManager: connect to keyboard BrightnessChanged signal to update the cached current value properly

To post a comment you must log in.
lp://qastaging/~3v1n0/unity-settings-daemon/keep-cached-kbd-backlight-updated updated
4135. By Marco Trevisan (Treviño)

PowerManager: return proper value on Toggle method call

4136. By Marco Trevisan (Treviño)

GsdPowerManager: implement "Toggle" as upstream

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

seems like that created bug #1592816, the upower_kbd_toggle return type changed and we need changes from https://git.gnome.org/browse/gnome-settings-daemon/commit/?id=5614e2c7a275a092e1fcf43450d7f0c5730c14bd

"- ret = upower_kbd_toggle (manager, &error);
+ value = upower_kbd_toggle (manager, &error);
+ ret = (value >= 0);"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches