Unity

Merge lp://qastaging/~3v1n0/unity/add-launcher-item-from-dbus into lp://qastaging/unity

add-launcher-item-from-dbus
Merge into trunk

Proposed by Marco Trevisan (Treviño) on 2012-09-20

Status:	Work in progress
Proposed branch:	lp://qastaging/~3v1n0/unity/add-launcher-item-from-dbus
Merge into:	lp://qastaging/unity
Diff against target:	145 lines (+99/-0) 3 files modified launcher/LauncherController.cpp (+50/-0) launcher/LauncherControllerPrivate.h (+1/-0) tests/test_launcher_controller.cpp (+48/-0)
To merge this branch:	bzr merge lp://qastaging/~3v1n0/unity/add-launcher-item-from-dbus
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Andrea Azzarone (community)		2012-09-20	Approve on 2012-10-02
Review via email: mp+125516@code.qastaging.launchpad.net

Commit message

LauncherController: add AddLauncherItem dbus method that allows to add a new .desktop file to the launcher

Description of the change

Add a new dbus method to Launcher Controller that allows to add a new application to the launcher, if the application icon is already in the launcher, the icon will be sticked to it.

This will allow to do:
gdbus call --session --dest com.canonical.Unity.Launcher --object-path /com/canonical/Unity/Launcher --method com.canonical.Unity.Launcher.AddLauncherItem <argument>

Where <argument> can be:

app.desktop
/path/to/app.desktop
application://app.desktop
application:///path/to/app.desktop
file:///path/to/app.desktop

Unit tests included.

lp://qastaging/~3v1n0/unity/add-launcher-item-from-dbus updated on 2012-09-20

2721. By Marco Trevisan (Treviño) on 2012-09-20: unityshell: reverts changes (not for this branch)

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2012-09-20:

why do we need it?

review: Needs Information

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2012-09-20:

Some OEM projects need it, they should attach a bug to this branch soon.

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2012-10-02:

LGTM.

review: Approve

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2012-10-02:

Keeping this on Hold for now, waiting to get more infos from the projects depending on this.

Unmerged revisions

2721. By Marco Trevisan (Treviño) on 2012-09-20: unityshell: reverts changes (not for this branch)
2720. By Marco Trevisan (Treviño) on 2012-09-20: TestLauncherController: added test for OnLauncherAddRequestDesktopFile
2719. By Marco Trevisan (Treviño) on 2012-09-20: LauncherController: add AddLauncherItem dbus method that allows to add a new .desktop file to the launcher
2718. By Marco Trevisan (Treviño) on 2012-09-20: Merging with trunk