Merge lp://qastaging/~3v1n0/unity/alt+tab-background-load.tests into lp://qastaging/unity
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Marco Trevisan (Treviño) |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2092 |
| Proposed branch: | lp://qastaging/~3v1n0/unity/alt+tab-background-load.tests |
| Merge into: | lp://qastaging/unity |
| Prerequisite: | lp://qastaging/~3v1n0/unity/alt+tab-background-load |
| Diff against target: |
262 lines (+141/-28) 5 files modified
plugins/unityshell/src/SwitcherController.h (+4/-4) plugins/unityshell/src/UnityWindowStyle.cpp (+1/-0) tests/CMakeLists.txt (+17/-6) tests/test_switcher_controller.cpp (+106/-0) tests/test_switcher_model.cpp (+13/-18) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/alt+tab-background-load.tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Penhey (community) | Approve | ||
| Andrea Azzarone (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Added tests for SwitcherController changes done in lp:~3v1n0/unity/alt+tab-background-load, enabled the SwitcherModel tests as well.
To post a comment you must log in.
Revision history for this message
| Tim Penhey (thumper) | # |
review:
Approve
Revision history for this message
| Marco Trevisan (Treviño) (3v1n0) wrote | # |
Revision history for this message
| Unity Merger (unity-merger) wrote | # |
Revision history for this message
| Unity Merger (unity-merger) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'm not a fan of having long sleeps in unit tests.
Can I suggest that you use perhaps a class level static value for the start time delay.
You can then change that to something small in the test. I'd say as small as possible to show what is going on.