Merge lp://qastaging/~3v1n0/unity/alt+tab-background-load into lp://qastaging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 2091
Proposed branch: lp://qastaging/~3v1n0/unity/alt+tab-background-load
Merge into: lp://qastaging/unity
Diff against target: 326 lines (+114/-60)
2 files modified
plugins/unityshell/src/SwitcherController.cpp (+104/-54)
plugins/unityshell/src/SwitcherController.h (+10/-6)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity/alt+tab-background-load
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Tim Penhey (community) Needs Fixing
Review via email: mp+94669@code.qastaging.launchpad.net

Description of the change

Add some background operations to the SwitcherController to make the Alt+Tab to show-up quicker

The switcher controller now when initialized setup a lazy timer (now set to 10s) that on timeout will construct the
switcher view, to make the first time usage quicker.

Also, I've added an idle that will run as soon as the user presses the switcher key combination, that constructs the view in background (and shows an invisible window, since the the ShowWindow operation can take longer than just setting the view visible) to make sure that when the show-timeout occurs everything is already there and it just needs to be shown (setting its opacity).

Tests included into the branch lp:~3v1n0/unity/alt+tab-background-load.tests

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

just a note: can you set the timer rather to 20s? (10s is quite short to have everything loaded on the desktop on machines).

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ok, I thought that 10 seconds were enough, considering that the timeout has low priority, ad so it shouldn't run during boot if there's something else to load, but I'll move that to 20s as you prefer.

Revision history for this message
Tim Penhey (thumper) wrote :

Comments on the test branch.

review: Needs Fixing
Revision history for this message
Andrea Azzarone (azzar1) :
review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/432/console reported an error when processing this lp:~3v1n0/unity/alt+tab-background-load branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.