Unity

Merge lp://qastaging/~3v1n0/unity/device-launcher-section-c++ into lp://qastaging/unity

device-launcher-section-c++
Merge into trunk

Proposed by Marco Trevisan (Treviño) on 2012-04-24

Status:

Merged

Approved by:

Andrea Azzarone on 2012-04-24

Approved revision:

no longer in the source branch.

Merged at revision:

2334

Proposed branch:

lp://qastaging/~3v1n0/unity/device-launcher-section-c++

Merge into:

lp://qastaging/unity

Diff against target:

265 lines (+59/-99)

4 files modified

plugins/unityshell/src/DeviceLauncherIcon.cpp (+1/-1)
plugins/unityshell/src/DeviceLauncherIcon.h (+2/-2)
plugins/unityshell/src/DeviceLauncherSection.cpp (+48/-75)
plugins/unityshell/src/DeviceLauncherSection.h (+8/-21)

To merge this branch:

bzr merge lp://qastaging/~3v1n0/unity/device-launcher-section-c++

Related bugs:

Bug #918548: compiz crashed with SIGSEGV in g_volume_get_mount()	High	Fix Released
Bug #977762: compiz crashed with SIGSEGV in g_volume_eject_with_operation_finish() from unity::launcher::DeviceLauncherIcon::OnEjectReady() from	High	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Andrea Azzarone (community)		2012-04-24	Approve on 2012-04-24
Review via email: mp+103349@code.qastaging.launchpad.net

Commit message

DeviceLauncherSection: updated to use glib::SignalManager and glib::Object

This allow to be more safe; it fixes also some crashes caused by the fact that DeviceLauncherIcon didn't own the GVolume* object. Now it uses glib::Object completely, so we can automagically ref/unref the volume when the icon is created/removed.