Merge lp://qastaging/~3v1n0/unity/flickerless-alt+f10-on-keydown into lp://qastaging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 2161
Proposed branch: lp://qastaging/~3v1n0/unity/flickerless-alt+f10-on-keydown
Merge into: lp://qastaging/unity
Diff against target: 219 lines (+56/-48)
7 files modified
manual-tests/PanelIndicators.txt (+21/-0)
plugins/unityshell/src/PanelController.cpp (+10/-33)
plugins/unityshell/src/PanelController.h (+1/-2)
plugins/unityshell/src/PanelView.cpp (+5/-6)
plugins/unityshell/src/PanelView.h (+1/-2)
plugins/unityshell/src/unityshell.cpp (+17/-5)
plugins/unityshell/src/unityshell.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity/flickerless-alt+f10-on-keydown
Reviewer Review Type Date Requested Status
Daniel van Vugt Needs Information
Tim Penhey (community) Approve
Review via email: mp+98918@code.qastaging.launchpad.net

Commit message

Open the Menus Indicators on ButtonPress avoiding flickers

Now the indicator menus shows once Alt+F10 keybinding has been pressed, and is not anymore needed to release the Alt key.
Also, fixed the panel issue reported in bug #948522 that could happen when using menus. To avoid it we use now a timeout to filter the events that we can ignore not to make unity-panel-service crazy.

Description of the change

Open the Menus Indicators on ButtonPress avoiding flickers

UNBLOCK as requested by didrocks

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

The code looks fine.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

3v1n0, your fix for this bug is missing the safety check to avoid crashing on Alt+Enter. Like we did for:
https://code.launchpad.net/~vanvugt/unity/fix-960957/+merge/98593

I wonder if that's going to be a problem?...

review: Needs Information
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

No, I thought about that while doing it, but I didn't include the check since it seems to cause troubles only on terminate cb, and we don't use that here.
On initiate, the action should be properly filled.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.