Merge lp://qastaging/~3v1n0/unity/keep-running-apps-on-unstick into lp://qastaging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3146
Proposed branch: lp://qastaging/~3v1n0/unity/keep-running-apps-on-unstick
Merge into: lp://qastaging/unity
Diff against target: 73 lines (+33/-15)
2 files modified
launcher/ApplicationLauncherIcon.cpp (+3/-0)
tests/test_application_launcher_icon.cpp (+30/-15)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity/keep-running-apps-on-unstick
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+147743@code.qastaging.launchpad.net

Commit message

ApplicationLauncherIcon: set the visibility of an unstick application based on its running state

Description of the change

We have a big regression that causes application icons to be removed when unlocked, regardless their running status.

Fixed here, tests provided.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Awesome catch, works for me and all tests pass.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.