Merge lp://qastaging/~3v1n0/unity/laucher-edge-reveal-revisited into lp://qastaging/unity
| Status: | Merged |
|---|---|
| Merged at revision: | 1328 |
| Proposed branch: | lp://qastaging/~3v1n0/unity/laucher-edge-reveal-revisited |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
115 lines (+51/-3) 3 files modified
plugins/unityshell/src/unityshell.cpp (+41/-2) plugins/unityshell/src/unityshell.h (+2/-0) plugins/unityshell/unityshell.xml.in (+8/-1) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/laucher-edge-reveal-revisited |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jason Smith (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
When using the edge revealing, the launcher is too slow to show and it often shows when not needed.
So, I've basically added a compiz option which allows to set the timeout to wait before showing the unity launcher, currently set to 150ms.
Then, I've introduced some more filters which should avoid unneeded revelations: basically after that the reveal timeout has been reached we also check if we didn't move "too much" the mouse along the Y axis; then if we didn't move, the launcher is shown, otherwise we retry to show the launcher until the mouse pointer is touching the left edge.
Another thing that I didn't implemented yet, but that could be considered, comes from the bug #801320: actually we only allow the launcher to show if the mouse pointer "hits" on the left screen edge, maybe we should allow also to show it if we stay on the pointerX "1px" for a longer time; maybe for something like 4*_edge_timeout, and we didn't move after this timeout (in the Y axis). Just let me know if this is something that I should add to this branch.
+1 looks good