Merge lp://qastaging/~3v1n0/unity/launcher-primary-monitor into lp://qastaging/unity
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Marco Trevisan (Treviño) |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2154 |
| Proposed branch: | lp://qastaging/~3v1n0/unity/launcher-primary-monitor |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
144 lines (+62/-22) 2 files modified
manual-tests/Launcher.txt (+19/-0) plugins/unityshell/src/LauncherController.cpp (+43/-22) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/launcher-primary-monitor |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrea Azzarone (community) | Approve | ||
|
Review via email:
|
|||
Commit message
LauncherController: show a launcher in the primary monitor if set
This ensures that the launcher is shown only on the primary one, not on the one at the left.
Description of the change
Make the Launcher controller be aware of the primary monitor.
This ensures that the launcher is shown only on the primary one.
Added a manual test for now, AP tests are already done, but needs to be polished.
I'll merge them soon.
18:03:18 <didrocks> just propose the branch with a manual test :)
18:03:30 <didrocks> for now
18:03:34 <didrocks> and automate later
18:06:15 <didrocks> tell in the MR that you discussed it with me
18:06:20 <didrocks> and UNBLOCK
;)
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me!