Merge lp://qastaging/~3v1n0/unity/lockscreen-media-accelerators into lp://qastaging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 4131
Proposed branch: lp://qastaging/~3v1n0/unity/lockscreen-media-accelerators
Merge into: lp://qastaging/unity
Diff against target: 657 lines (+196/-175)
11 files modified
lockscreen/LockScreenAcceleratorController.cpp (+143/-148)
lockscreen/LockScreenAcceleratorController.h (+8/-3)
lockscreen/LockScreenAccelerators.cpp (+5/-0)
lockscreen/LockScreenAccelerators.h (+3/-1)
lockscreen/LockScreenController.cpp (+3/-1)
lockscreen/LockScreenController.h (+3/-1)
plugins/unityshell/src/unityshell.cpp (+10/-10)
tests/test_lockscreen_controller.cpp (+8/-4)
unity-shared/GnomeKeyGrabber.cpp (+7/-5)
unity-shared/GnomeKeyGrabberImpl.h (+2/-2)
unity-shared/KeyGrabber.h (+4/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity/lockscreen-media-accelerators
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+297978@code.qastaging.launchpad.net

Commit message

LockScreenAcceleratorController: use key::Grabber to handle allowed bindings

This makes U-S-D to handle key events, without having to add some extra
custom code inside the lockscreen. It's all just about whitelisting the
wanted values.

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.