Merge lp://qastaging/~3v1n0/unity/lowgfx-setting-sync into lp://qastaging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 4250
Proposed branch: lp://qastaging/~3v1n0/unity/lowgfx-setting-sync
Merge into: lp://qastaging/unity
Prerequisite: lp://qastaging/~3v1n0/unity/unity-settings-signal-blocking
Diff against target: 309 lines (+105/-33)
6 files modified
plugins/unityshell/src/unityshell.cpp (+6/-12)
tests/data/external.gschema.xml (+7/-1)
tools/compiz-profile-selector.in (+19/-7)
tools/unity.cmake (+7/-4)
unity-shared/UnitySettings.cpp (+65/-9)
unity-shared/UnitySettings.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity/lowgfx-setting-sync
Reviewer Review Type Date Requested Status
Andrea Azzarone (community) Approve
Review via email: mp+327523@code.qastaging.launchpad.net

Commit message

UnitySettings: listen to compiz profile status in order to set low_gfx value

Instead of changing this value back and forth multiple times, just wait
this to be really changed in compiz, and update our internal variable
accordingly.
Also take care of the gsettings unity's lowgfx value only if the user has
set it.

This fixes an infinite loop when starting compiz in a lowgfx environment.

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.