Merge lp://qastaging/~3v1n0/unity/manage-user-invisible-windows into lp://qastaging/unity
| Status: | Merged |
|---|---|
| Approved by: | Didier Roche-Tolomelli |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1830 |
| Proposed branch: | lp://qastaging/~3v1n0/unity/manage-user-invisible-windows |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
266 lines (+108/-24) 2 files modified
manual-tests/UserInvisibleWindows.txt (+47/-0) plugins/unityshell/src/BamfLauncherIcon.cpp (+61/-24) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/manage-user-invisible-windows |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mirco Müller (community) | Approve | ||
| Jason Smith | Pending | ||
|
Review via email:
|
|||
Description of the change
Making unity be aware of user-invisible windows, and manage them correctly.
Fixed bug #784804, but after a discussion with Jason I followed his guidelines to get the things fixed.
Basically now user-invisible windows (i.e. the ones with the skip-taskbar flag) are ignored by unity unless they don't belong to a sticky application. In that case the application is shown as running, but clicking on it makes the application to run a new instance (while the alt+tab allows to select the user-invisible windows).
When an application as both user visible and invisible windows, clicking on the launcher icon or the alt+tab gives priority to the visible windows when bringing them to focus, while when closing all the visible windows, the application is hidden from launcher and alt+tab unless it's sticky (and in this case it behaves as explained above).
Also the user-invisible windows, never increment the count of the running windows (i.e. the launcher "pips").
Read more cases in the provided manual-tests.
This branch also fixes the management of the urgent windows, that with some latest commits were not managed anymore as they should (now they get again priority when the parent application is focused).
| Unity Merger (unity-merger) wrote | # |
+1 code looks ok and the manual tests work as described. I used cairo-clock and nautilus (copy large amounts of data around my disk) to reproduce the manual-tests. For future testers I strongly recommend to add these explicit hints to the manuals tests description of what applications to use for the manual-tests. Otherwise other testers will have a hard time with reproducing them.