Merge lp://qastaging/~3v1n0/unity/middle-click-paste-in-dash into lp://qastaging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Mirco Müller
Approved revision: no longer in the source branch.
Merged at revision: 1870
Proposed branch: lp://qastaging/~3v1n0/unity/middle-click-paste-in-dash
Merge into: lp://qastaging/unity
Diff against target: 218 lines (+59/-33)
3 files modified
manual-tests/Dash.txt (+15/-0)
plugins/unityshell/src/IMTextEntry.cpp (+39/-29)
plugins/unityshell/src/IMTextEntry.h (+5/-4)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity/middle-click-paste-in-dash
Reviewer Review Type Date Requested Status
Mirco Müller (community) Approve
Andrea Azzarone (community) Approve
Review via email: mp+87311@code.qastaging.launchpad.net

Description of the change

Add support to middle-click pasting on the dash search bar.

When the XA_PRIMARY clipboard has some content, that is pasted by middle click over the dash search bar.
This is for consistency with the rest of the system.

I've also added the proper glib::Object support to the class.

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

Middle-click pasting doesn't work. Only Ctrl-V allows me to paste into the dash's search-bar.

review: Needs Fixing
Revision history for this message
Andrea Azzarone (azzar1) wrote :

150 + if (!im_enabled)
151 + return;

This if is no longer needed.

review: Needs Fixing
Revision history for this message
Andrea Azzarone (azzar1) wrote :

Just to be clear you should do either:

if (button == 3 and im_enabled)
{
}
else if (button == 2)
or

if (!im_enabled and button != 2)
  return;

if (button == 3)
{
}
else if (button == 2)
{
}

...

I'd prefer the former.

Revision history for this message
Andrea Azzarone (azzar1) :
review: Approve
Revision history for this message
Andrea Azzarone (azzar1) wrote :

+1

Revision history for this message
Mirco Müller (macslow) wrote :

Finally works now for me too.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.