Merge lp://qastaging/~3v1n0/unity/panel-alt+tab-update into lp://qastaging/unity
Proposed by
Marco Trevisan (Treviño)
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1829 |
Proposed branch: | lp://qastaging/~3v1n0/unity/panel-alt+tab-update |
Merge into: | lp://qastaging/unity |
Diff against target: |
327 lines (+114/-28) 6 files modified
manual-tests/Panel.txt (+15/-0) plugins/unityshell/src/PanelMenuView.cpp (+76/-25) plugins/unityshell/src/PanelMenuView.h (+9/-2) plugins/unityshell/src/SwitcherController.cpp (+10/-0) plugins/unityshell/src/SwitcherController.h (+0/-1) plugins/unityshell/src/UBusMessages.h (+4/-0) |
To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/panel-alt+tab-update |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mirco Müller (community) | Approve | ||
Review via email:
|
Description of the change
Update the top panel title with the current alt+tab focused application title.
Fixed bug #855516, using ubus messages to make the switcher notify of events.
To post a comment you must log in.
Works as described and code looks mostly ok. Just add a "paranoia"-check to data and self for...
void PanelMenuView: :OnSwitcherShow n(GVariant* data, PanelMenuView* self) :OnSwitcherSele ctionChanged( GVariant* data, PanelMenuView* self)
void PanelMenuView:
... making sure they are not NULL.