Merge lp://qastaging/~3v1n0/unity/panel-alt+tab-update into lp://qastaging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: no longer in the source branch.
Merged at revision: 1829
Proposed branch: lp://qastaging/~3v1n0/unity/panel-alt+tab-update
Merge into: lp://qastaging/unity
Diff against target: 327 lines (+114/-28)
6 files modified
manual-tests/Panel.txt (+15/-0)
plugins/unityshell/src/PanelMenuView.cpp (+76/-25)
plugins/unityshell/src/PanelMenuView.h (+9/-2)
plugins/unityshell/src/SwitcherController.cpp (+10/-0)
plugins/unityshell/src/SwitcherController.h (+0/-1)
plugins/unityshell/src/UBusMessages.h (+4/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity/panel-alt+tab-update
Reviewer Review Type Date Requested Status
Mirco Müller (community) Approve
Review via email: mp+88014@code.qastaging.launchpad.net

Description of the change

Update the top panel title with the current alt+tab focused application title.

Fixed bug #855516, using ubus messages to make the switcher notify of events.

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

Works as described and code looks mostly ok. Just add a "paranoia"-check to data and self for...

  void PanelMenuView::OnSwitcherShown(GVariant* data, PanelMenuView* self)
  void PanelMenuView::OnSwitcherSelectionChanged(GVariant* data, PanelMenuView* self)

... making sure they are not NULL.

review: Needs Fixing
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Checks added, even if they shouldn't be needed since the callback is unregistered when this is destroyed... Anyway double-checking is always good :)

Revision history for this message
Mirco Müller (macslow) wrote :

+1

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/116/console reported an error when processing this lp:~3v1n0/unity/panel-alt+tab-update branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.