Merge lp://qastaging/~3v1n0/unity/panel-p-cleanup into lp://qastaging/unity
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2242 |
Proposed branch: | lp://qastaging/~3v1n0/unity/panel-p-cleanup |
Merge into: | lp://qastaging/unity |
Diff against target: |
7874 lines (+3128/-2131) 28 files modified
UnityCore/Variant.cpp (+31/-2) UnityCore/Variant.h (+6/-1) plugins/unityshell/src/DashController.cpp (+5/-3) plugins/unityshell/src/DashController.h (+1/-0) plugins/unityshell/src/LauncherController.cpp (+51/-8) plugins/unityshell/src/PanelController.cpp (+27/-20) plugins/unityshell/src/PanelController.h (+2/-4) plugins/unityshell/src/PanelIndicatorEntryView.cpp (+440/-347) plugins/unityshell/src/PanelIndicatorEntryView.h (+69/-45) plugins/unityshell/src/PanelIndicatorsView.cpp (+103/-42) plugins/unityshell/src/PanelIndicatorsView.h (+27/-18) plugins/unityshell/src/PanelMenuView.cpp (+934/-859) plugins/unityshell/src/PanelMenuView.h (+78/-90) plugins/unityshell/src/PanelTitlebarGrabAreaView.cpp (+125/-13) plugins/unityshell/src/PanelTitlebarGrabAreaView.h (+27/-6) plugins/unityshell/src/PanelTray.cpp (+92/-115) plugins/unityshell/src/PanelTray.h (+21/-24) plugins/unityshell/src/PanelView.cpp (+123/-149) plugins/unityshell/src/PanelView.h (+40/-45) plugins/unityshell/src/PluginAdapter.cpp (+158/-24) plugins/unityshell/src/PluginAdapter.h (+12/-3) plugins/unityshell/src/SwitcherController.cpp (+9/-2) plugins/unityshell/src/UBusMessages.h (+1/-0) plugins/unityshell/src/WindowButtons.cpp (+587/-220) plugins/unityshell/src/WindowButtons.h (+33/-12) plugins/unityshell/src/WindowManager.cpp (+38/-10) plugins/unityshell/src/WindowManager.h (+12/-6) plugins/unityshell/src/unityshell.cpp (+76/-63) |
To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/panel-p-cleanup |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Penhey (community) | Approve | ||
Review via email: mp+99950@code.qastaging.launchpad.net |
Commit message
A lot of panel fixes with code cleanup and improvements to the panel code.
This branch introduces a lot of code cleanup and improvements to the panel code.
A part the linked bugs fixed, this changes:
- PanelStyle: used now to check all the panel related settings, including
fonts and DPI. Emitting the changed signal when they get changed (so now
when changing the title font, it gets updated immediately).
Added better support for HighContrast themes and fallback buttons.
Used ti everywhere to remove the "24" height magic number.
- PanelIndicatorE
and modified to be easily extendible in the near future. Also fixed issues
with the indicator entries and Scale/Expo
- PanelMenuView: the layout system has been rewritten and now it works
natively without the workarounds we were using before,
fixed the panel paddings to match design specs;
Optimized the drawing operations, now the title texture is cached and
rebuilt only if really needed.
Fixed the panel title on Expo and Scale.
Improved the detection of the panel used to draw the app title on
multi-monitor (disabled otherwise), and the alt+tab/alt conflict.
Maximized windows list is re-populated on startup or when adding a new
screen.
- PanelTitlebarGr
and clicks over it.
- WindowButtons: rewritten using in a better way the subclass nux::Button
features, factorizing some code for each button into WindowButtons. Also
the handling of the controlled window is now done internally, not by the
PanelMenuView.
Description of the change
A lot of panel fixes... Into one branch, because they should go together, but the single changes are shown on these single code reviews:
1) PanelStyle changes: http://
2) Indicator Entry changes: http://
3) Indicators View changes: http://
4) Window buttons changes: http://
5) Grab area changes: http://
6) Tray changes: http://
7) Window Manager changes: http://
8) Core changes: http://
9) Menu view changes: http://
10) Panel view changes: http://
This branch introduces a lot of code cleanup and improvements to the panel code.
A part the linked bugs fixed, this changes:
- PanelStyle: used now to check all the panel related settings, including
fonts and DPI. Emitting the changed signal when they get changed (so now
when changing the title font, it gets updated immediately).
Added better support for HighContrast themes and fallback buttons.
Used ti everywhere to remove the "24" height magic number.
- PanelIndicatorE
and modified to be easily extendible in the near future. Also fixed issues
with the indicator entries and Scale/Expo
- PanelMenuView: the layout system has been rewritten and now it works
natively without the workarounds we were using before,
fixed the panel paddings to match design specs;
Optimized the drawing operations, now the title texture is cached and
rebuilt only if really needed.
Fixed the panel title on Expo and Scale.
Improved the detection of the panel used to draw the app title on
multi-monitor (disabled otherwise), and the alt+tab/alt conflict.
Maximized windows list is re-populated on startup or when adding a new
screen.
- PanelTitlebarGr
and clicks over it.
- WindowButtons: rewritten using in a better way the subclass nux::Button
features, factorizing some code for each button into WindowButtons. Also
the handling of the controlled window is now done internally, not by the
PanelMenuView.
Testing:
- All the panel items now are introspectable. And this allow AP testing.
- The branch with all the brand new tests for the panel are at:
lp:~3v1n0/unity/panel-p-tests
OMG, WTF? 7.5k lines in the last week? This had better work :-)