Merge lp://qastaging/~3v1n0/unity/panel-shadow-draw-fixes into lp://qastaging/unity

Proposed by Marco Trevisan (Treviño)
Status: Merged
Approved by: Andrea Azzarone
Approved revision: no longer in the source branch.
Merged at revision: 3208
Proposed branch: lp://qastaging/~3v1n0/unity/panel-shadow-draw-fixes
Merge into: lp://qastaging/unity
Diff against target: 157 lines (+35/-38)
2 files modified
plugins/unityshell/src/unityshell.cpp (+34/-38)
plugins/unityshell/src/unityshell.h (+1/-0)
To merge this branch: bzr merge lp://qastaging/~3v1n0/unity/panel-shadow-draw-fixes
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Andrea Azzarone (community) Approve
Brandon Schaefer (community) Approve
Review via email: mp+152750@code.qastaging.launchpad.net

Commit message

UnityWindow: properly draw the panel shadow when a Nux window is focused or during WS switch

If a nux window is the active one, compiz won't draw it, so the code that is doing the
panelShadow drawing is excluded. We need to make sure that this will be executed
also in this case.

Description of the change

Optimizations: unity at every window redraw was executing a loop to check if a window was or not a nux one. Now we set this value on UnityWindow initialization, making the check a lot less expensive.
Removed some uneeded initializations on paintPanelShadow, and using uscreen's GetMonitorAtPosition instead of an extra loop.

Fixes: nux windows are currently excluded from the compiz draw process, this lead to not executing the paintPanelShadow code into UnityWindow::glDraw, so we need to call this in glPaint to get the proper panel shadow to be drawn when the launcher, the dash/hud or shutdown dialogues are fucused.
Also, making the panel shadow to redraw properly on transformed output.

To post a comment you must log in.
Revision history for this message
Andrea Azzarone (azzar1) wrote :

I get a darker shadow on an empty vp (pressing alt+f1 or opening the shutdown dialog).

review: Needs Fixing
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM, works :)

review: Approve
Revision history for this message
Andrea Azzarone (azzar1) wrote :

/me doesn't like the shadow behaviour during the VP switch.

review: Abstain
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

> /me doesn't like the shadow behaviour during the VP switch.

Reverted to the previous status, but here I've still a bug :(

Revision history for this message
Andrea Azzarone (azzar1) wrote :

LGTM now. Thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Azzarone (azzar1) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.