Merge lp://qastaging/~3v1n0/unity/panelmenu-on-mousegrab-fixes into lp://qastaging/unity
Proposed by
Marco Trevisan (Treviño)
| Status: | Merged |
|---|---|
| Approved by: | Tim Penhey |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1771 |
| Proposed branch: | lp://qastaging/~3v1n0/unity/panelmenu-on-mousegrab-fixes |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
167 lines (+70/-15) 6 files modified
manual-tests/PanelIndicators.txt (+27/-0) plugins/unityshell/src/PanelIndicatorsView.cpp (+9/-8) plugins/unityshell/src/PanelIndicatorsView.h (+2/-2) plugins/unityshell/src/PanelMenuView.cpp (+20/-1) plugins/unityshell/src/PanelMenuView.h (+2/-0) plugins/unityshell/src/PanelView.cpp (+10/-4) |
| To merge this branch: | bzr merge lp://qastaging/~3v1n0/unity/panelmenu-on-mousegrab-fixes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Penhey (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fixing bug #888650 and bug #890970 which caused the global menubar to not correctly react to mouse events when an indicator menu is open.
Since compiz can't get the mouse position when the unity-panel-service grabs the mouse, we need to manually update the mouse position and send it to the menubar to make it correctly draw also when the Nux events aren't emitted.
Tests for this code will come as soon as possible (i.e when the autopilot will be completed).
To post a comment you must log in.
Revision history for this message
| Marco Trevisan (Treviño) (3v1n0) wrote | # |
Revision history for this message
| Tim Penhey (thumper) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Code looks good to me.
One point, can you use the new "nullptr" from the C++11 standard instead of "NULL" please.
Perhaps this will be best tested with autopilot?
Marking as needs fixing until we can find a test for this.